fix: resolve all failing tests and type errors#7
Open
stooit wants to merge 1 commit into
Open
Conversation
- Implement paginate() utility in shared package - Fix User type field name: userName -> username for consistency - Fix auth middleware case-sensitivity bug for HTTP method matching - Add missing badRequest helper import in users route - Add bun-types to tsconfig for proper type resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paginate()utility inpackages/shared/src/utils/pagination.ts— was a stub throwing "not implemented"packages/shared/src/types.ts— changeduserNametousernameto match test expectationspackages/api/src/middleware/auth.ts— HTTP method comparison now case-insensitive so POST routes correctly bypass authpackages/api/src/routes/users.ts— added inlinebadRequestresponse helperbun-typesto tsconfig — enables proper type resolution forbun:testandprocessglobalsVerification
All 22 tests pass (
bun test) andtsc --noEmitexits cleanly with zero errors.Assumptions
bun-typespackage was already installed innode_modules(no new dependency added)processglobal declaration was removed from auth.ts in favour of the tsconfig types fixbadRequestwas implemented inline as a simple 400 JSON response helper since no shared utility existed